Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flow #5126

Merged
merged 3 commits into from
Aug 10, 2017
Merged

More flow #5126

merged 3 commits into from
Aug 10, 2017

Conversation

jfirebaugh
Copy link
Contributor

I set out to remove as many anys as I could from popup.js and marker.js, and discovered that I needed a MapMouseEvent type first. So I reorganized map event types and docs, then did the original task.

What's nice about this organization is the documentation for each map event type is next to its entry in the MapEvent enum, so we can see where we're missing documentation (e.g. #4772), or missing enum values.

@jfirebaugh jfirebaugh requested a review from mollymerp August 9, 2017 21:34
src/ui/events.js Outdated
* @memberof Map
* @instance
* @property {MapMouseEvent} data
* @see [Highlight features under the mouse pointer](https://www.mapbox.com/mapbox-gl-js/example/hover-styles/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm this example actually uses the mouseleave event, not mouseout. Are we not defining the events on L165-167 because they're self explanatory or for some other reason?

Copy link
Contributor

@mollymerp mollymerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this! I realize now that we're already missing docs for those three events in my earlier comment and now its just more obvious 😂 . I do think we should maybe remove that see example for mouseout or change the example.

@jfirebaugh
Copy link
Contributor Author

Yeah, I think I'll just go ahead and add docs for mouseleave etc., and move the example.

@jfirebaugh jfirebaugh merged commit 8a68233 into master Aug 10, 2017
@jfirebaugh jfirebaugh deleted the more-flow branch August 10, 2017 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants