Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DDS for text-max-width property #5067

Merged
merged 3 commits into from
Aug 1, 2017
Merged

Conversation

nickidlugash
Copy link

Implements DDS for text-max-width property

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • manually test the debug page

@ChrisLoer
Copy link
Contributor

Awesome! This looks great. Do you think you could add a test for the zoom-and-property case? Like the other symbol layout properties, text-max-width will be a little bit funky in that case and it'd be nice to have the expected behavior in a test case. My expectation is that if you have zoom stops at 5 and 7, and you render a tile at zoom 6.5, you should get max-width interpolated as if it were at zoom level 6.

@nickidlugash
Copy link
Author

@ChrisLoer Added, thanks 👍

Copy link
Contributor

@mollymerp mollymerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks nicki!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants