Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zoom-function #5028

Merged
merged 3 commits into from
Jul 25, 2017
Merged

Fix zoom-function #5028

merged 3 commits into from
Jul 25, 2017

Conversation

edpop
Copy link
Contributor

@edpop edpop commented Jul 24, 2017

Good day.
Fix a case when interpolationFactor returned NaN (:heart: javascript)
Fixes #4942

jfirebaugh
jfirebaugh reviewed Jul 24, 2017
View reviewed changes
Copy link
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you change it to return 0 in this case, to match mapbox-gl-native?

@edpop
Copy link
Contributor Author

edpop commented Jul 24, 2017

Done. The icons look good.
I don't know, what better to do with this test https://github.com/mapbox/mapbox-gl-js/blob/v0.39.0/test/unit/style-spec/function.test.js#L59.

@jfirebaugh
Copy link
Contributor

You fixed the issue with NaN, so I believe the assertion should be changed to t.equal(f(17), 11) and the comment should be deleted.

@jfirebaugh jfirebaugh merged commit 923a6bc into mapbox:master Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfirebaugh jfirebaugh jfirebaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edpop @jfirebaugh