Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Implement property functions for line-cap, line-join" #5018

Merged
merged 1 commit into from
Jul 21, 2017

Conversation

lbud
Copy link
Contributor

@lbud lbud commented Jul 21, 2017

Reverts #5010. I totally jumped the gun on this one and didn't ensure that it works with dashed lines (it doesn't — draw_line relies on line-cap to get the dash pattern for a full tile (not per-property) so this isn't a quick fix unfortunately 🕵️‍♀️ )

Copy link
Contributor

@mollymerp mollymerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@lbud lbud merged commit 268199f into master Jul 21, 2017
@lbud lbud deleted the revert-5010-line-capjoin-dds branch July 21, 2017 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants