Increase minimum supercluster version #5002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supercluster version needs to be 2.3.0 at minimum to populate the cluster_id property of clusters. This property is a useful reference when using a second instance of supercluster to aggregate properties or explore cluster members.
mourner
approved these changes
Jul 20, 2017
|
Thank you! |
|
Should this also bump yarn.lock? https://github.com/mapbox/mapbox-gl-js/blob/master/yarn.lock#L6077 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider increasing the supercluster version to ^2.3.0. This version of supercluser populates a cluster_id property of all clusters that it generates. This property is a useful cross reference when using a second instance of the supercluster object to aggregate properties or explore cluster members. Such functionality appears to be planned for integration into mapbox-gl-js per discussion in #2412 at which point the newer supercluster release would become a requirement.
In any case, supercluster 2.0.1 lacks the large performance improvement in version 2.1.0, and the release version of mapbox-gl-js is built against 2.2.0. So this ought to be bumped for other reasons as well.
👀 @jfirebaugh