Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DDS for text-justify property #5000

Merged
merged 1 commit into from
Jul 21, 2017
Merged

Implement DDS for text-justify property #5000

merged 1 commit into from
Jul 21, 2017

Conversation

nickidlugash
Copy link

Implements DDS for text-justify property.

Locally, 3 tests are failing (debug/collision-pitched, debug/collision-pitched-wrapped, and extent/1024-symbol). Not sure what's wrong, but the diffs seem very minor. @ChrisLoer any ideas? 🙏

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • manually test the debug page

@nickidlugash nickidlugash mentioned this pull request Jul 20, 2017
Closed
@jfirebaugh jfirebaugh mentioned this pull request Jul 20, 2017
Open
@ChrisLoer
Copy link
Contributor

Huh, normally the tests work locally and fail on CI... ;) I ran the test suite for this branch locally on my machine and everything was fine.

The debug/collision tests are very sensitive -- I wonder if they're picking up the same "unique" behavior you mentioned your graphics card seemed to have? What happens if you check out master and run the tests?

ChrisLoer
ChrisLoer approved these changes Jul 20, 2017
View reviewed changes
Copy link
Contributor

@ChrisLoer ChrisLoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me although we should separately investigate the local test failures.

mollymerp
mollymerp approved these changes Jul 20, 2017
View reviewed changes
Copy link
Contributor

@mollymerp mollymerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw I was getting weird failures on those two tests as well. #4939 ups the allowable diff to 0.005.

@nickidlugash
Copy link
Author

Thanks, @ChrisLoer @mollymerp !

@nickidlugash nickidlugash merged commit b01514c into master Jul 21, 2017
@nickidlugash nickidlugash deleted the dds-text-justify branch July 21, 2017 16:29
@lbud lbud mentioned this pull request Jul 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mollymerp mollymerp mollymerp approved these changes

@ChrisLoer ChrisLoer ChrisLoer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickidlugash @ChrisLoer @mollymerp