Increase significantRotateThreshold, fix #4970

[dagjomar]

Ref #4970

From user testing and feedback I have found that the old threshold value of 4 is too low, causing map to rotate when users are trying to simply pinch zoom the map.

Tested with higher values than 10, but found that 10 is a good value.

Changed the significantRotateThreshold from 4 to 10

Launch Checklist

• briefly describe the changes in this PR
• write tests for all new functionality
• document any changes to public APIs
• post benchmark scores
• manually test the debug page

[mourner]

This sounds good to me!

Should we also increase the default value of bearingSnap option? It controls how much you have to rotate before it stops snapping back to north. The current value is 7, which also might be a bit low.

[dagjomar]

Regarding also changing bearingSnap value, it sounds like a good idea, as currently, it is difficult to actually perceive that there exist such a value. (As a user, I am trying to make the map snap north, but unable to make it perceivably happen)

However, that is secondary in importance, and requires some more manual user testing before a value can be confidently set. I can also see some potential caveats with a high value for that, and it begs for it to be an customizable property. Or at least possible to have map.bearingSnap: false - or even 0 to turn it off and other values to set it custom.

[mourner]

and it begs for it to be an customizable property

It is already — it's a public bearingSnap map option.

[dagjomar]

@mourner Wow, that is great! Sorry, I didn't check if it was already an optional value, I just assumed it wasn't because all the values looked like private consts when I glimsed on the code.

Well, anyway, great!