Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix thrown exception with certain calls to flyTo #4761

Merged
merged 1 commit into from
May 29, 2017
Merged

Conversation

mollymerp
Copy link
Contributor

Fix #4753

@mourner some cases where w0 and w1 were very similar, but w1 was zoomed out significantly from w0 were causing r() to return infinity, causing S to be initially set at NaN.

Not sure if this fix is how you'd do it but it manages to avoid the thrown Failed to Invert Matrix.

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page

@mollymerp mollymerp requested a review from mourner May 26, 2017 17:50
@mollymerp mollymerp merged commit cb34199 into master May 29, 2017
@mollymerp mollymerp deleted the flyto-fix branch May 29, 2017 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map.flyTo is throwing a typeError: failed to invert matrix
2 participants