Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip newly added image-add tests for native. #4652

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Skip newly added image-add tests for native. #4652

merged 1 commit into from
Apr 27, 2017

Conversation

asheemmamoowala
Copy link
Contributor

@asheemmamoowala asheemmamoowala requested a review from lbud April 27, 2017 21:40
lbud
lbud approved these changes Apr 27, 2017
View reviewed changes
Copy link
Contributor

@lbud lbud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jfirebaugh
jfirebaugh approved these changes Apr 27, 2017
View reviewed changes
Copy link
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "ignored" is preferable to "skipped" in this case.

  • ignored -- run the test, but don't fail the build if the result doesn't match. You can still look at the diff to see what needs fixing.
  • skipped -- don't even run the test. We generally use this only if the test would crash the test harness or otherwise interfere with other tests.

@asheemmamoowala
Copy link
Contributor Author

Thanks @jfirebaugh, I was wondering about the difference.

@asheemmamoowala asheemmamoowala merged commit da4c62f into master Apr 27, 2017
@jfirebaugh jfirebaugh deleted the skip-image-tests-for-native branch April 27, 2017 21:50
@lbud
Copy link
Contributor

lbud commented Apr 27, 2017

Thanks for the quick fix @asheemmamoowala 🙇‍♀️

@asheemmamoowala asheemmamoowala restored the skip-image-tests-for-native branch April 27, 2017 22:24
@asheemmamoowala asheemmamoowala mentioned this pull request Apr 27, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbud lbud lbud approved these changes

@jfirebaugh jfirebaugh jfirebaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asheemmamoowala @lbud @jfirebaugh