Ensure generated composite function stops are in the correct order #4509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 28, 2017 09:48
This captures a bug in the generated stops used by the implementation of composite functions, wherein zoom stops were sorted lexicographically rather than numerically.
Iterating over zoom levels as object keys did not guarantee ordering, and resulted in, e.g. the stop for 2.1 coming after the one for 3
12 tasks
mourner
approved these changes
Mar 28, 2017
lucaswoj
pushed a commit
that referenced
this pull request
Mar 29, 2017
…4509) * Test composite function w/ int & fractional stops This captures a bug in the generated stops used by the implementation of composite functions, wherein zoom stops were sorted lexicographically rather than numerically. * Ensure generated composite function stops are in the correct order Iterating over zoom levels as object keys did not guarantee ordering, and resulted in, e.g. the stop for 2.1 coming after the one for 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the generated stops used by the implementation of composite
functions, wherein zoom stops were sorted lexicographically rather than
numerically.