Set default maxZoom to 22 #4333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jingsam. Can you fix the test failure? |
I don't know why this test failed, please help me check it out |
|
I think the problem is this line, which requests a zoom of 21. Prior to your change, the default max zoom would affect the result, producing an effective zoom level of 20. Now it's actually rendering at 21. Try changing the line to |
|
OK for now |
jfirebaugh
approved these changes
Feb 28, 2017
|
Thanks! |
|
mapbox/mapbox-gl-native#8318 tracks doing the same in the native SDKs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I know, all mapbox public sources such as satellite and streets are 0~22 zoom level. And maps in Mapbox studio can be zoomed into 22 max level. However, the default maxZoom level for mapbox-gl-js is 20. This cause inconsistency when a developer zoomed his maps in Mapbox studio to 22 and get stuck at 20 in his application. The shared URL provided by mapbox studio also stuck at 20. I know developers can set default maxZoom of mapbox-gl-js to 22 explicitly, but it needs some effort for them to figure out the solution.