Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex filters in style buckets #430

Merged
merged 16 commits into from
Jun 5, 2014
Merged

Complex filters in style buckets #430

merged 16 commits into from
Jun 5, 2014

Conversation

mourner
Copy link
Member

@mourner mourner commented Jun 5, 2014

Implements #407, MongoDB-style except the differences discussed. Covered with tests.

{
  'foo': {'>': 5, '<=': 16},
  '$or': [
    '$and': [
      '$not': {'bar': 'baz'},
      'foo': {'!=': 10}
    ],
    'cool': {'$exists': true}
  ]
}

Operators implemented:

  • $lt (<), $gt (>), $lte (<=), $gte (>=), $ne (!=), $exists
  • $or (||), $and (&&), $nor ('!': [...])
  • $not ('!': {...})

@mourner mourner added this to the v1.0.0 milestone Jun 5, 2014
This was referenced Jun 5, 2014
@mourner
Copy link
Member Author

mourner commented Jun 5, 2014

The build fails because of @tmcw's recent tests — safe to merge.

@ansis
Copy link
Contributor

ansis commented Jun 5, 2014

Nice implementation!

@ansis ansis closed this Jun 5, 2014
@ansis ansis reopened this Jun 5, 2014
ansis added a commit that referenced this pull request Jun 5, 2014
Complex filters in style buckets
@ansis ansis merged commit ed9f5f3 into master Jun 5, 2014
@ansis ansis deleted the complex-filters branch June 5, 2014 21:24
bensleveritt pushed a commit to bensleveritt/mapbox-gl-js that referenced this pull request Oct 24, 2016
Consistify exiting draw modes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants