Get rid of util inherit, extendAll, debounce, coalesce, startsWith #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
force-pushed
the
no-util-inherit
branch
from
cf0cc3e to
7109fdb
Compare
mourner
changed the title
mourner
changed the title
jfirebaugh
approved these changes
Oct 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got rid of:
util.inheritafter @jfirebaugh mentioned it in Unexport or document mapboxgl.util #1408 (comment). Not needed with ES6 classes.util.extendAll(not needed much withoutinherit).utildebounce,coalesceandstartsWith— they seem not to be used anymore.