Avoid unnecessary style validation #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is unused following #3209.
* Don't validate mapbox:// styles * Don't validate data in the worker * Don't revalidate previously-validated data
|
daang great perf gains!! 🎉 |
|
Note that |
|
I've noticed that too @mourner. I'll look into it. |
captainbarbosa
pushed a commit
that referenced
this pull request
Oct 3, 2016
* Remove dead code This code is unused following #3209. * Avoid unnecessary style validation * Don't validate mapbox:// styles * Don't validate data in the worker * Don't revalidate previously-validated data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unnecessary style validation:
This PR does not expose a
validateoption at the API level yet.Benchmarks
map-load
master c0f1c7e: 272 ms
style-load-perf b2e5679: 89 ms
style-load
master c0f1c7e: 163 ms
style-load-perf b2e5679: 112 ms
buffer
master c0f1c7e: 1,032 ms
style-load-perf b2e5679: 989 ms
fps
master c0f1c7e: 60 fps
style-load-perf b2e5679: 60 fps
frame-duration
master c0f1c7e: 7.3 ms, 0% > 16ms
style-load-perf b2e5679: 7.3 ms, 0% > 16ms
query-point
master c0f1c7e: 1.01 ms
style-load-perf b2e5679: 1.33 ms
query-box
master c0f1c7e: 64.97 ms
style-load-perf b2e5679: 68.48 ms
geojson-setdata-small
master c0f1c7e: 12 ms
style-load-perf b2e5679: 13 ms
geojson-setdata-large
master c0f1c7e: 121 ms
style-load-perf b2e5679: 113 ms
Launch Checklist