Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tiles preloading when a source is not yet loaded #12699

Merged
merged 4 commits into from
May 10, 2023
Merged

Fix tiles preloading when a source is not yet loaded #12699

merged 4 commits into from
May 10, 2023

Conversation

stepankuzmin
Copy link
Contributor

@stepankuzmin stepankuzmin commented May 8, 2023 •
edited
Loading

Use map transform in the case when a source is not yet loaded when preloading tiles. Closes #12696

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Fix tiles preloading when a source is not yet loaded</changelog>

@stepankuzmin stepankuzmin requested a review from mourner May 8, 2023 11:49
@stepankuzmin stepankuzmin mentioned this pull request May 8, 2023
Closed
@stepankuzmin stepankuzmin marked this pull request as ready for review May 8, 2023 11:49
@stepankuzmin stepankuzmin requested a review from a team as a code owner May 8, 2023 11:49
@stepankuzmin stepankuzmin marked this pull request as draft May 8, 2023 12:05
@stepankuzmin stepankuzmin marked this pull request as ready for review May 8, 2023 12:29
@stepankuzmin
Copy link
Contributor Author

CodeBuild fails while installing dependencies:

error An unexpected error occurred: "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.188.0.tgz: unexpected end of file".

mourner
mourner requested changes May 9, 2023
View reviewed changes
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good — can we add a unit test for it?

mourner
mourner requested changes May 9, 2023
View reviewed changes
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good — can we add a unit test for it?

@stepankuzmin stepankuzmin requested a review from mourner May 10, 2023 12:57
@stepankuzmin stepankuzmin merged commit 25d64f3 into main May 10, 2023
@stepankuzmin stepankuzmin deleted the fix-12696 branch May 10, 2023 13:45
@kallyas kallyas mentioned this pull request Jul 17, 2024
Merged
@yash509 yash509 mentioned this pull request Sep 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
bug 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

map.preloadOnly does not work (exception fired)
2 participants
@stepankuzmin @mourner