Add the isPointOnSurface method
#12695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepankuzmin
commented
May 5, 2023
Comment on lines
+1367
to
+1368
| const coord = this.pointCoordinate(p); | ||
| return coord.y >= 0 && coord.y <= 1; |
There was a problem hiding this comment.
This check works well for the Mercator projection, but I need to figure out how to properly check this for alternate projections.
There was a problem hiding this comment.
is there a way currently to use this method properly on globe projection?
mourner
approved these changes
May 5, 2023
Co-authored-by: Volodymyr Agafonkin <[email protected]>
|
Also needs a fix to the unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
isPointOnSurfacemap method to determine if the given point is located on a visible map surface.Launch Checklist
mapbox-gl-jschangelog:<changelog>Add the "isPointOnSurface" map method to determine if the given point is located on a visible map surface.</changelog>