Code

Alternate zoom with terrain#12354

Code

Merged

avpeery merged 50 commits intomainmapbox/mapbox-gl-js:mainfrom alternate-zoom-with-terrainmapbox/mapbox-gl-js:alternate-zoom-with-terrainCopy head branch name to clipboardDec 13, 2022

+150-54

Commits

Commits on Sep 30, 2022

• remove code that pitches camera above terrain WIP

  avpeery

  committed
  1159341

Commits on Oct 7, 2022

• WIP

  avpeery

  committed
  5364b04

Commits on Oct 11, 2022

• remove changing z position and updating camera orientation

  avpeery

  committed
  47504b8

• re-add change to minHeight

  avpeery

  committed
  b01337e

• remove extra spacing

  avpeery

  committed
  5e01266

Commits on Oct 13, 2022

• update integration tests - since pitch is not being adjusted

  avpeery

  committed
  da3d155

Commits on Oct 18, 2022

• fix failing unit tests, remove unused code

  avpeery

  committed
  b5cb3ac

• add new render test to show camera stops and doesn't pitch when colliding with terrain

  avpeery

  committed
  e590e8e

Commits on Oct 19, 2022

• fix clipping terrain with drag gestures

  avpeery

  committed
  7ad12dc

• formatting fix

  avpeery

  committed
  f434e74

• revert to original comment

  avpeery

  committed
  9556be9

• decreased clipping

  avpeery

  committed
  5c70f09

• removing orientation change - does not help lessen clipping

  avpeery

  committed
  59c4b2a

• update render tests

  avpeery

  committed
  2636f8f

• run constrainCamera when camera is moving and when potential style or data changes

  avpeery

  committed
  30e461f

• typo

  avpeery

  committed
  619f578

Commits on Oct 20, 2022

• update averageElevation unit test

  avpeery

  committed
  2e7e89e

Commits on Oct 26, 2022

• reset pitch and bearing for unit test

  avpeery

  committed
  4001079

• skip constraining when zooming as it is already contrained

  avpeery

  committed
  f159782

• change comment

  avpeery

  committed
  62e080f

• add comment to explain hard-coding 85 value

  avpeery

  committed
  6fb34fe

• Wording

  Show description for 7454aef
  

  avpeery

  and

  SnailBones

  authored
  7454aef

Commits on Nov 2, 2022

• divide logic between under terrain and safe distance from terrain

  avpeery

  committed
  9818d69

• stop zooming at safe distance from terrain

  avpeery

  committed
  793f74d

• update to _isCameraConstrained

  avpeery

  committed
  8c1de95

• update camera state add back in

  avpeery

  committed
  821aa0e

Commits on Nov 3, 2022

• add isDragging check

  avpeery

  committed
  51fb421

Commits on Nov 4, 2022

• prevent sliding when zooming into terrain

  avpeery

  committed
  1759ba5

• unneeded changes

  avpeery

  committed
  fa64d10

• unneeded change

  avpeery

  committed
  6f2355a

• bump back minimum height to avoid any clipping through terrain

  avpeery

  committed
  1cac447

Commits on Nov 8, 2022

• catch double click and double tap zoom events

  avpeery

  committed
  9890b39

• fix flow issues

  avpeery

  committed
  3796928

Commits on Nov 9, 2022

• update unit tests

  avpeery

  committed
  71814dc

• update render tests

  avpeery

  committed
  1ec5bd6

• use default value for constrainCamera

  avpeery

  committed
  9683c27

Commits on Nov 18, 2022

• don't change minimum height based on maxPitch

  avpeery

  committed
  01536c1

• resolve situation when zooming with keyboard

  avpeery

  committed
  20bbce5

• control keyboard zooming

  avpeery

  committed
  7775495

• simplify logic

  avpeery

  committed
  b51a88a

• set camera position directly

  avpeery

  committed
  e40ef59

• fix unit test

  avpeery

  committed
  a4bf61c

• update render test

  avpeery

  committed
  2afa50d

• add default argument for isDragging

  avpeery

  committed
  b061c73

• removed comment

  avpeery

  committed
  af15e40

Commits on Dec 9, 2022

• Merge branch 'main' into alternate-zoom-with-terrain

  avpeery

  committed
  fdfeac2

Commits on Dec 12, 2022

• update setting camera position, rename isDragging

  avpeery

  committed
  b790159

• only update camera state when updating camera position

  avpeery

  committed
  96f5c5d

Commits on Dec 13, 2022

• decided against constraining keyboard panning and zooming

  avpeery

  committed
  34d921e

• Clarify naming

  Show description for 6020e65
  

  avpeery

  and

  karimnaaji

  authored
  6020e65