Reload tiles after TileJSON is loaded in VectorTileSource#setSourceProperty #11963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepankuzmin
added
release blocker ⛔
skip changelog
mourner
approved these changes
Jun 8, 2022
|
There are some significant remaining issues with localization such as #11969 that need to be addressed. But we can merge as is to get the partial fix into the release since this is not yet a public feature. |
karimnaaji
pushed a commit
that referenced
this pull request
Jun 8, 2022
…operty (#11963) * Reload tiles after TileJSON is loaded in setSourceProperty * add more i18n tests * drop the language validation * mark i18n API as private
karimnaaji
added a commit
that referenced
this pull request
Jun 8, 2022
* beta.2 * Reload tiles after TileJSON is loaded in VectorTileSource#setSourceProperty (#11963) * Reload tiles after TileJSON is loaded in setSourceProperty * add more i18n tests * drop the language validation * mark i18n API as private * update s3 link to lower res video (#11965) Co-authored-by: Stepan Kuzmin <[email protected]> Co-authored-by: Anna Peery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR postpones tiles reloading until TileJSON is loaded in
VectorTileSource#setSourceProperty.This fixes the race condition in #11952, when tiles are being requested with the old
languageandworldviewoptions before the requested TileJSON updates the source'stilesproperty inVectorTileSource#load.This PR also removes the language checks from client, see #11968
Launch Checklist
mapbox-gl-jschangelog:<changelog></changelog>