Simplify and consolidate globe atmosphere uniforms #11756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karimnaaji
added
the
skip changelog
karimnaaji
force-pushed
the
karim/consolidate-globe-uniforms
branch
from
74bbb61 to
edf8d67
Compare
Fixup
karimnaaji
force-pushed
the
karim/consolidate-globe-uniforms
branch
from
edf8d67 to
8bd2a5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplification to address review comment #11590 (comment) and follow up from #11590.
globeCenterInViewSpaceandglobeRadiusmoving its frequency from once per draw call to once per frame