-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Globe occlusion for popups and improving marker performance on globe #11658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karimnaaji
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @SnailBones ! I've left a few nits, but the one missing thing before merging is adding a small test for popup occlusion, otherwise good to merge at your convenience.
Co-authored-by: Karim Naaji <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
#11556 added support for marker and popup position on globe and marker occlusion behind globe. This PR adds occlusion for markers that are not attached to a popup.
Also improves the occlusion algorithm as described here: #11556 (review)
Also fixes a minor bug where a marker behind terrain and in fog would have its fog opacity calculated at the point of the intersecting terrain, not the marker itself. i.e. in some cases marker opacity would increase when the marker was hidden behind terrain.
Other changes are refactoring for code readability and removing repetition.
A future optimization could include caching the result to reduce calls to
latLngToECEF
, though this may not be worth the added complexity.Fog support + terrain occlusion for markerless popups.mapbox-gl-js
changelog:<changelog>Fix markers in fog sometimes becoming more visible when behind terrain. </changelog>