Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geolocation adapter for customizing geolocation in GeolocateControl #11614

Merged
merged 6 commits into from
Apr 18, 2022

Conversation

mourner
Copy link
Member

@mourner mourner commented Mar 17, 2022

This is a rebase of #10400 with Flow / unit tests fixed — that PR got stuck not reporting CI for some reason.

const myGeolocation = {
   clearWatch: ...,
   getCurrentPosition: ...,
   watchPosition: ...,
};

map.addControl(new GeolocateControl({
   geolocation: myGeolocation
}));

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Add an option for providing a geolocation adapter to GeolocateControl</changelog>

@karimnaaji karimnaaji merged commit b3a24e6 into main Apr 18, 2022
@karimnaaji karimnaaji deleted the pr/10400-rebased branch April 18, 2022 21:59
@mourner mourner mentioned this pull request Jul 11, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants