Fix globe atmosphere precision on Android/iOS-OpenGLES #11610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Computation and varying require highp in OpenGL ES.
astojilj
changed the title
karimnaaji
approved these changes
Mar 15, 2022
ahocevar
pushed a commit
to ahocevar/mapbox-gl-js
that referenced
this pull request
Mar 23, 2022
Computation and varying require highp in OpenGL ES. Co-authored-by: Aleksandar Stojiljković <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After porting to gl-native, it is noticeable that computation and varying require highp in OpenGL ES. E.g. Pixel 5, before after:
Launch Checklist
- [ ] write tests for all new functionalitytests exist, gl native tests this on various hardware.- [ ] document any changes to public APIs- [ ] post benchmark scores@mapbox/map-design-team@mapbox/static-apisif this PR includes style spec API or visual changes@mapbox/gl-nativeif this PR includes shader changes or needs a native port- [ ] apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'- [ ] add an entry inside this element for inclusion in themapbox-gl-jschangelog:<changelog></changelog>