Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow] Enable type-first mode #11605

Merged
merged 3 commits into from
Mar 15, 2022
Merged

[Flow] Enable type-first mode #11605

merged 3 commits into from
Mar 15, 2022

Conversation

mourner
Copy link
Member

@mourner mourner commented Mar 15, 2022

A part of #11426. Adds remaining missing export types across many files and FINALLY enables Flow type-first mode, which brings a massive performance and reliability improvement to type checking in our codebase.

@mourner mourner requested a review from stepankuzmin March 15, 2022 15:53
@mourner mourner marked this pull request as ready for review March 15, 2022 16:04
Copy link
Contributor

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mourner mourner merged commit d7e1beb into main Mar 15, 2022
@mourner mourner deleted the flow/typefirst branch March 15, 2022 16:16
ahocevar pushed a commit to ahocevar/mapbox-gl-js that referenced this pull request Mar 23, 2022
* add remaining missing types and enable type-first mode

* fix remaining errors

* actually enable typefirst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants