Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update ImageAtlas render callbacks after image removal #11580

Merged
merged 1 commit into from
Mar 11, 2022
Merged

fix: update ImageAtlas render callbacks after image removal #11580

merged 1 commit into from
Mar 11, 2022

Conversation

stepankuzmin
Copy link
Contributor

ImageAtlas may still have render callbacks after removing the image in ImageManager.

Closes #11558

Launch Checklist

  • briefly describe the changes in this PR
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>fix: properly handle animated images render callbacks removal</changelog>

@stepankuzmin stepankuzmin requested a review from ansis March 9, 2022 10:33
@stepankuzmin stepankuzmin self-assigned this Mar 10, 2022
@stepankuzmin stepankuzmin merged commit a132353 into main Mar 11, 2022
@stepankuzmin stepankuzmin deleted the fix-image-atlas-render-callbacks branch March 11, 2022 11:01
ahocevar pushed a commit to ahocevar/mapbox-gl-js that referenced this pull request Mar 23, 2022
@stepankuzmin @ahocevar
fix: update ImageAtlas render callbacks after image removal (mapbox#1…
5bb0a8d 
…1580)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanhamley ryanhamley ryanhamley approved these changes

@ansis ansis Awaiting requested review from ansis

Assignees

@stepankuzmin stepankuzmin

Labels
bug 🐞
Projects
None yet
Milestone
No milestone
2 participants
@stepankuzmin @ryanhamley