Simplifying marker rotation #11563
Merged
Simplifying marker rotation #11563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SnailBones
force-pushed
the
aidan/marker-refactor
branch
from
6407e99 to
05441e3
Compare
SnailBones
added
the
skip changelog
karimnaaji
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR. I remove the
marker._transformedOffsetfunction and instead perform transformations directly in the CSS transform.Since CSS transformations can be view as occurring from right to left, by adding this transform on the right of the rotations, it means that the offset translation occurs first and the rotations now act on the correct origin.
This makes way for #11556, which will now be better isolated to only the changes necessary for globe support.
Launch Checklist