Code

Globe view marker support#11556

Code

Merged

SnailBones merged 30 commits intomainmapbox/mapbox-gl-js:mainfrom aidan/globe-markersmapbox/mapbox-gl-js:aidan/globe-markersCopy head branch name to clipboardMar 29, 2022

+403-55

Commits

Commits on Feb 25, 2022

• transform.locationPoint3D to return 2d variant with globe

  SnailBones

  committed
  245d19d

  Copy full SHA for 245d19d

Commits on Feb 26, 2022

• Added map.usingGlobe() and improving Flow typing

  SnailBones

  committed
  ff8b63e

  Copy full SHA for ff8b63e

• Hiding markers and popups and disabling click interactions when behind globe

  SnailBones

  committed
  a2d3d02

  Copy full SHA for a2d3d02

Commits on Mar 2, 2022

• Clarifying variable names

  SnailBones

  committed
  fd8ce5a

  Copy full SHA for fd8ce5a

• Marker rotation responds to globe, first attempt at pitch

  SnailBones

  committed
  ec0b559

  Copy full SHA for ec0b559

Commits on Mar 3, 2022

• Fix to marker pitch 'auto' inconsistency

  SnailBones

  committed
  6e5a202

  Copy full SHA for 6e5a202

• Default to no pitch on globe

  SnailBones

  committed
  43280d9

  Copy full SHA for 43280d9

• Fix type error

  SnailBones

  committed
  64a0d49

  Copy full SHA for 64a0d49

• Changed map.usingGlobe to private _usingGlobe()

  SnailBones

  committed
  22c00a3

  Copy full SHA for 22c00a3

Commits on Mar 4, 2022

• Merge branch 'main' into aidan/globe-markers

  SnailBones

  committed
  a4a9eb8

  Copy full SHA for a4a9eb8

• Add conditional transform ordering logic so markers lean forward with pitch-alignment:map in globe without change to 2d behavior

  SnailBones

  committed
  0208496

  Copy full SHA for 0208496

• Limit max marker pitch and fix false occlusion at center

  SnailBones

  committed
  727043d

  Copy full SHA for 727043d

• Always return fallback pitch/rotation alignment instead of 'auto'

  SnailBones

  committed
  b95d0d1

  Copy full SHA for b95d0d1

Commits on Mar 5, 2022

• Map pitch effects marker pitch

  SnailBones

  committed
  13f0c1a

  Copy full SHA for 13f0c1a

Commits on Mar 21, 2022

• Merge branch 'main' into aidan/globe-markers

  SnailBones

  committed
  02d934f

  Copy full SHA for 02d934f

Commits on Mar 22, 2022

• Adding Flow types for fl-matrix

  SnailBones

  committed
  41b7d0a

  Copy full SHA for 41b7d0a

• Adding marker draping. Removed new marker layout options

  SnailBones

  committed
  f265dcd

  Copy full SHA for f265dcd

• Removing unused variables

  SnailBones

  committed
  99ff18d

  Copy full SHA for 99ff18d

• Don't add rotations of 0 to CSS and update tests to pass

  SnailBones

  committed
  5802b24

  Copy full SHA for 5802b24

• Adding test for marker offset

  SnailBones

  committed
  a1208dd

  Copy full SHA for a1208dd

• Adding test for default marker position

  SnailBones

  committed
  805bcc7

  Copy full SHA for 805bcc7

• Adding unit tests covering marker position and transform on globe

  SnailBones

  committed
  0c7b515

  Copy full SHA for 0c7b515

• Cleaning up marker transform functions

  SnailBones

  committed
  4e1004b

  Copy full SHA for 4e1004b

Commits on Mar 23, 2022

• Expanding test for pitch

  SnailBones

  committed
  15f6e28

  Copy full SHA for 15f6e28

Commits on Mar 25, 2022

• Apply suggestions from code review

  Show description for a57f8e4
  

  SnailBones

  and

  karimnaaji

  authored
  a57f8e4

  Copy full SHA for a57f8e4

• Code cleanup and switch to atan2

  SnailBones

  committed
  d43c5c3

  Copy full SHA for d43c5c3

• Clarifying comment about occlusion edge case

  SnailBones

  committed
  7da2d4c

  Copy full SHA for 7da2d4c

• Using helper function

  SnailBones

  committed
  615388d

  Copy full SHA for 615388d

Commits on Mar 29, 2022

• Update example so markers are centered

  SnailBones

  committed
  1a2ab66

  Copy full SHA for 1a2ab66

• Simplifying check for terrain by moving logic to projection.js

  SnailBones

  committed
  1e25213

  Copy full SHA for 1e25213