Allow the second argument to 'in' expression to be an empty string #11547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avpeery
reviewed
Feb 28, 2022
| @@ -42,7 +42,7 @@ class In implements Expression { | |||
| const needle = (this.needle.evaluate(ctx): any); | |||
| const haystack = (this.haystack.evaluate(ctx): any); | |||
|
|
|||
| if (!haystack) return false; | |||
| if (haystack == null) return false; | |||
There was a problem hiding this comment.
Should this be triple equals? Will == null on an empty string ever evaluate as true?
There was a problem hiding this comment.
This is a way of detecting undefined and null values while allowing other falsey values to pass through.
undefined == null // true
null == null // true
false == null // false
'' == null // false
avpeery
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
into be an empty string. this makes sense because''.indexOf('') >= 0is true, but the current implementation returns false.mapbox-gl-jschangelog:<changelog>Allow the second argument to the 'in' expression operator to be an empty string</changelog>