Switch style-spec scripts to native ESM #11538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
requested changes
Feb 21, 2022
There was a problem hiding this comment.
Great to see this neglected part of the code being addressed! One thing that doesn't feel quite right to me in this approach is copying the scripts from GL JS to run the binaries — it's fragile and complicated. Could we simplify this somehow? Perhaps rely on the built version of the style spec instead so that we don't have to use the loader?
mourner
requested changes
Feb 21, 2022
mourner
approved these changes
Feb 22, 2022
| @@ -0,0 +1,20 @@ | |||
| #!/usr/bin/env node | |||
| /* eslint-disable import/no-unresolved, no-process-exit */ | |||
There was a problem hiding this comment.
Nit: import/no-unresolved no longer needed
There was a problem hiding this comment.
Unfortunately in that case we need to add the @mapbox/mapbox-gl-style-spec as a dependency to itself, or silence ESLint with
/* eslint import/no-unresolved: [error, { ignore: ['^@mapbox/mapbox-gl-style-spec$'] }] */
I've updated the PR to ignore the unresolved @mapbox/mapbox-gl-style-spec import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts style-spec scripts to native ESM and checks these scripts happy-path as a part of CI.
Closes #10965
Launch Checklist
mapbox-gl-jschangelog:<changelog>fix: convert style-spec scripts to native ESM</changelog>