[Flow] Type exports for data/* #11472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
changed the title
karimnaaji
reviewed
Feb 4, 2022
src/data/bucket/symbol_bucket.js
Outdated
| @@ -598,7 +598,7 @@ class SymbolBucket implements Bucket { | |||
| } | |||
| } | |||
|
|
|||
| addToLineVertexArray(anchor: Anchor, line: any) { | |||
| addToLineVertexArray(anchor: Anchor, line: any): {| lineLength: number, lineStartIndex: number |} { | |||
There was a problem hiding this comment.
What style should we follow concerning inlined anonymous type? I sometimes find it nice to read a named type instead (e.g. addToLineVertexArray(anchor: Anchor, line: any): LineVertexRange) as a hint to what it is. This can also reduce very long function signature like here.
We don't have to switch all of the ones we already have, but since we're going to add a lot of these now I wonder if we should adopt a particular convention.
There was a problem hiding this comment.
Good point — this return type was auto-generated, but I agree that extracting it into a named type makes it more readable (and perhaps it will be useful in the future once we need to specify this type in other files). Fixed.
karimnaaji
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part of #11426. Adds missing export types for files in
src/data/*apart fromarray_types.jswhich is in #11470.