Upgrade Flow to v0.142.0 #11456
Merged
Upgrade Flow to v0.142.0 #11456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
force-pushed
the
upgrade-flow-4
branch
from
619ac4c to
67b0693
Compare
12 tasks
ansis
approved these changes
Feb 2, 2022
SnailBones
reviewed
Feb 2, 2022
| @@ -16,7 +14,7 @@ class RasterDEMTileWorkerSource { | |||
| loadTile(params: WorkerDEMTileParameters, callback: WorkerDEMTileCallback) { | |||
| const {uid, encoding, rawImageData, padding, buildQuadTree} = params; | |||
| // Main thread will transfer ImageBitmap if offscreen decode with OffscreenCanvas is supported, else it will transfer an already decoded image. | |||
| const imagePixels = (ImageBitmap && rawImageData instanceof ImageBitmap) ? this.getImageData(rawImageData, padding) : rawImageData; | |||
| const imagePixels = rawImageData instanceof RGBAImage ? rawImageData : this.getImageData(rawImageData, padding); | |||
There was a problem hiding this comment.
This change breaks terrain in Firefox, which doesn't support OffscreenCanvas. This check fails since rawImageData is of type ImageData.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #11426. This PR upgrades Flow to v0.132.0, a version which forbids using implicit
anyas a type, which previously led to incorrectly typed or untyped code that Flow ignored. Similar to #11400 but extends to all other libraries we import. Then further upgrades to v0.142.0, the last version that supportstypes_first = false.In particular, adds types for
@mapbox/grid-indexand@mapbox/tiny-sdf(previously untyped and assumedObject=any), and makes surePointtype is used explicitly where it's referenced (for some reason Flow didn't complain when it didn't). Also note that I had to disable a few errors withanyor$FlowFixMein places where proper typing is very difficult — I would leave fixing this for later when we're on the latest Flow version.Launch Checklist