Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log a warning when the map container isn't empty #11404

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Log a warning when the map container isn't empty #11404

merged 2 commits into from
Jan 18, 2022

Conversation

ryanhamley
Copy link
Contributor

@ryanhamley ryanhamley commented Jan 14, 2022 •
edited
Loading

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog></changelog>

@ryanhamley ryanhamley added the skip changelog Used for PRs that do not need a changelog entry label Jan 14, 2022
@avpeery avpeery merged commit 6c36428 into main Jan 18, 2022
@avpeery avpeery deleted the warn-on-non-empty-container branch January 18, 2022 15:46
@ryanhamley ryanhamley requested review from ansis and removed request for ansis January 18, 2022 18:21
mourner added a commit that referenced this pull request Jan 19, 2022
@mourner
Merge branch 'main' into flow-type-gl-matrix
5f01645 
* main:
  Fix variable anchors on globe (#11395)
  Log a warning when the map container isn't empty (#11404)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avpeery avpeery avpeery approved these changes

Assignees
No one assigned
Labels
skip changelog Used for PRs that do not need a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Y offset if elements exist within map, since 1.9.0
2 participants
@ryanhamley @avpeery