Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a queryTerrainElevation example to API doc #10748

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Conversation

domlet
Copy link
Contributor

@domlet domlet commented Jun 4, 2021

Launch Checklist

  • Adds a queryTerrainElevation example to API doc

  • briefly describe the changes in this PR

  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'

@domlet domlet added docs 📜 skip changelog Used for PRs that do not need a changelog entry labels Jun 4, 2021
@domlet domlet requested a review from HeyStenson June 4, 2021 15:09
Copy link
Contributor

@karimnaaji karimnaaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 we can also add a reference example to this one https://docs.mapbox.com/mapbox-gl-js/example/add-fog/ for the setFog API.

@domlet
Copy link
Contributor Author

domlet commented Jun 4, 2021

👍 we can also add a reference example to this one https://docs.mapbox.com/mapbox-gl-js/example/add-fog/ for the setFog API.

Love it. Added in cbb8134 – look good? @karimnaaji

Copy link
Contributor

@HeyStenson HeyStenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karimnaaji
Copy link
Contributor

Thanks @domlet . Merging.

@karimnaaji karimnaaji merged commit e9ee222 into main Jun 4, 2021
@karimnaaji karimnaaji deleted the db-addqueryexample branch June 4, 2021 19:43
SnailBones pushed a commit to SnailBones/mapbox-gl-js that referenced this pull request Jul 15, 2021
* add queryTerrainElevation example to API doc

* add related example to setFog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs 📜 skip changelog Used for PRs that do not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants