Disable fog tile culling with low horizon-blend #10679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karimnaaji
approved these changes
May 18, 2021
rreusser
added a commit
that referenced
this pull request
May 28, 2021
karimnaaji
pushed a commit
that referenced
this pull request
Jun 1, 2021
* Implement dual ESM + CJS compatibility in style-spec (#10718) * Implement dual ESM + CJS compatibility in style-spec * Try to catch additional references to non-cjs files * Remove accidentally-committed files * Revert main entry point * Revert module field as well * Update sources and markers while fog transitioning (#10691) * Update sources while fog transitioning * Apply fix to markers * Remove unnecessary comment * Include dist/package.json in npm published files (#10668) * Disable fog tile culling with low horizon-blend (#10679) * Cherry-pick changelogs
SnailBones
pushed a commit
to SnailBones/mapbox-gl-js
that referenced
this pull request
Jul 15, 2021
* Implement dual ESM + CJS compatibility in style-spec (mapbox#10718) * Implement dual ESM + CJS compatibility in style-spec * Try to catch additional references to non-cjs files * Remove accidentally-committed files * Revert main entry point * Revert module field as well * Update sources and markers while fog transitioning (mapbox#10691) * Update sources while fog transitioning * Apply fix to markers * Remove unnecessary comment * Include dist/package.json in npm published files (mapbox#10668) * Disable fog tile culling with low horizon-blend (mapbox#10679) * Cherry-pick changelogs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #10677
Addresses sky showing through culled high elevation terrain by simply disabling fog tile culling when
horizon-blend< 0.03.I don't necessarily think I caught the worst spot in the world, so 0.03 is a little forgiving. I think as little as 0.02 might be safe but probably cuts it a little close.
Original:
Threshold < 0.01:
Threshold < 0.02:
Threshold < 0.03:
The look of the overall map with 0.03:
Here's the worst case I could find where it's not fully patched over by the 0.03 threshold, but it's so slight that I think it might be permissible:
If not we could simply bump it up to 0.04.
I mainly just want to be sure that we don't sacrifice useful tile culling for a range of parameters people are likely to spend a lot of time in, but I think this is probably acceptable.