Don't overwrite symbol bucket's iconsInText flag #10558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is at least one symbol that has inlined image(s), layer should be rendered by text&icon program. This change forces symbol bucket's iconsInText flag to be enabled, even if some of the symbol's images are evaluated to an empty resolved image.
ghost
mentioned this pull request
The test verifies that symbol bucket's iconsInText flag is not overwritten when there are symbols whose inlined images are evaluated to an empty image.
alexshalamov
force-pushed
the
alexshalamov_dont_overwrite_iconsInText_flag
branch
from
603aa61 to
eb024e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is at least one symbol that has inlined image(s), layer should be rendered by text&icon program. This change forces symbol bucket's
iconsInTextflag to be enabled, even if some of the symbol's images are evaluated to an empty resolved image.Without the fix, inline images could be rendered by a wrong program, thus, an image is sampled from a wrong texture:
After the fix:
Fixes: #10552
Launch Checklist
document any changes to public APIspost benchmark scorestagged@mapbox/map-design-team@mapbox/static-apisif this PR includes style spec API or visual changes@mapbox/gl-nativeif this PR includes shader changes or needs a native portmapbox-gl-jschangelog:<changelog>Do not overwrite symbol bucket's iconsInText flag, so that inline images are rendered by a correct program</changelog>