Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linked types to MapWheelEvent and MapTouchEvent #10525

Merged
merged 3 commits into from
Apr 8, 2021
Merged

Add linked types to MapWheelEvent and MapTouchEvent #10525

merged 3 commits into from
Apr 8, 2021

Conversation

domlet
Copy link
Contributor

@domlet domlet commented Mar 30, 2021 •
edited
Loading

Related to: https://github.com/mapbox/mapbox-gl-js-docs/issues/305 , https://github.com/mapbox/mapbox-gl-js-docs/issues/307

Improves developer experience by explicating event types and offering links.

  • Extends the pattern seen in: #mapmouseevent#type.
  • Adds a list of linked types to MapWheelEvent and MapTouchEvent.
  • Consistifies event documentation on this page.
  • Requesting Docs review from @mapbox/docs
  • Requesting GL JS review from @mapbox/gl-js

Before/after screenshot:

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • tagged @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes
  • tagged @mapbox/gl-native if this PR includes shader changes or needs a native port
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog></changelog>

@domlet domlet marked this pull request as ready for review March 31, 2021 01:47
HeyStenson
HeyStenson reviewed Apr 6, 2021
View reviewed changes
src/ui/events.js Outdated Show resolved Hide resolved
@asheemmamoowala asheemmamoowala requested review from ryanhamley and removed request for asheemmamoowala April 6, 2021 16:04
@ghost ghost mentioned this pull request Apr 7, 2021
Closed
domlet
domlet commented Apr 7, 2021
View reviewed changes
src/ui/events.js Outdated Show resolved Hide resolved
@domlet domlet requested review from HeyStenson and ryanhamley and removed request for ryanhamley April 7, 2021 21:55
HeyStenson
HeyStenson approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@HeyStenson HeyStenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🍊

@mourner mourner merged commit 92be4e0 into main Apr 8, 2021
@mourner mourner deleted the db-eventtypesconsistify branch April 8, 2021 08:05
@domlet domlet removed the request for review from ryanhamley April 8, 2021 15:41
domlet pushed a commit that referenced this pull request Apr 15, 2021
Revert "Add linked types to MapWheelEvent and MapTouchEvent (#10525)"
c049a80 
This reverts commit 92be4e0.
@domlet domlet mentioned this pull request Apr 15, 2021
Merged
domlet pushed a commit that referenced this pull request Apr 19, 2021
Revert "Add linked types to MapWheelEvent and MapTouchEvent (#10525)" (…
e22e78e 
…#10580)

This reverts commit 92be4e0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeyStenson HeyStenson HeyStenson approved these changes

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domlet @mourner @HeyStenson