Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect style serialization when using raster DEM tile sources #10418

Merged
merged 3 commits into from
Mar 2, 2021

Conversation

karimnaaji
Copy link
Contributor

@karimnaaji karimnaaji commented Feb 26, 2021

Fix for #10416, introducing incorrect diffing of styles when using raster dem tile sources, which resulted in reloading the scene in Studio when making any sort of style changes while using terrain.

Before vs After in studio:

bug.mov
fix.mov

Launch Checklist

  • briefly describe the changes in this PR
  • [n/a] include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • [n/a] document any changes to public APIs
  • [n/a] post benchmark scores
  • manually test the debug page
  • [n/a] tagged @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes
  • [n/a] tagged @mapbox/gl-native if this PR includes shader changes or needs a native port
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Fix incorrect diffing of styles when using raster DEM tile sources</changelog>

@karimnaaji karimnaaji added this to the v2.2 milestone Mar 1, 2021
Copy link
Contributor

@arindam1993 arindam1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and nice fix, actually removing code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants