feat: send geolocation as adapter

[behnammodi]

• This PR can help developers to customize geolocation behavior.
• We don't have any visual changes.
• All test cases compatible with these changes.
• I need your opinion and then add a document.

So now we have:

const myGeolocation: Geolocation = {
   clearWatch: ...,
   getCurrentPosition: ...,
   watchPosition: ...,
};

const geolocateControl = new GeolocateControl({
   geolocation: myGeolocation,
});

map.addControl(geolocateControl);

I'll say welcome to your awesome feedback :)

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
6 out of 14 committers have signed the CLA.

✅ behnammodi
✅ mourner
✅ andycalder
✅ asheemmamoowala
✅ anderswi
✅ kawsndriy
❌ arindam1993
❌ ansis
❌ mpulkki-mapbox
❌ ryanhamley
❌ ChrisLoer
❌ thefifthisa
❌ karimnaaji
❌ astojilj
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[andrewharvey]

What's the motivation or use case for this? Isn't window.navigator.geolocation really the only geolocation provider? How else would it be provided if not window.navigator.geolocation?

[behnammodi]

@andrewharvey You're right but this PR related to #10234 (comment), by this PR we can override the geolocation function.

for example, we want to show a popup UI before getting the user's location or ignore some coordinates

[behnammodi]

@andrewharvey Also imagine we going to enhance user location by their behavior and we don't want to relying on native geolocation.

[ImanMh]

What's the motivation or use case for this? Isn't window.navigator.geolocation really the only geolocation provider? How else would it be provided if not window.navigator.geolocation?

Same issue here, I want to build a PWA wrapped in a native app. In this case I prefer native app to provide GPS coordinates but with this implementation mapbox goes directly to the browser APIs.

[behnammodi]

@ImanMh Thanks, It's an awesome use case

[behnammodi]

@andrewharvey what is your opinion?

[ansis]

@mourner this looks good to me. Thoughts?

[asheemmamoowala]

so we need a rebase by me or somebody else?

@behnammodi it's best if you can rebase and verify the changes locally before merging the changes.

[behnammodi]

@asheemmamoowala All right, I will do it

[behnammodi]

@asheemmamoowala I did it, but I need someone to help me for 4 failed stage

[karimnaaji]

@behnammodi , I rebased your branch off of main in https://github.com/mapbox/mapbox-gl-js/tree/karim/behnammodi-pr10232-rebased.

The CI job did not pass on unit tests and build (render tests failure is unrelated), https://app.circleci.com/pipelines/github/mapbox/mapbox-gl-js/5920/workflows/4ebe7ae1-c43f-425e-bbcc-2e62cf6c29d0.

Could you try the following:

git remote add upstream [email protected]:mapbox/mapbox-gl-js
git fetch upstream
git checkout upstream/karim/behnammodi-pr10232-rebased
git checkout -b geolocation-as-adapter-rebased
git push origin main

And then open up a new PR so the discussion can continue on a clean diff? We'll close this PR then.

[behnammodi]

@karimnaaji Thank you for your help, I did it #10400

[karimnaaji]

@behnammodi Sounds good, thanks the diff look more approachable now! Closing this PR and I'll tag whoever was involved in reviewing this one there.