-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace style_locations with @mapbox/gazetteer #8059
Labels
Comments
tristen
added a commit
to mapbox/gazetteer
that referenced
this issue
Mar 21, 2019
Adds a tileIndex value for each location as [x, y]. This data will be helplful for letting style-benchmark-locations replace the locally managed style_locations.js doc in Mapbox GL JS. Closes #38 Ref mapbox/mapbox-gl-js#8059
tristen
added a commit
that referenced
this issue
Mar 21, 2019
tristen
added a commit
that referenced
this issue
Mar 21, 2019
tristen
added a commit
that referenced
this issue
Mar 21, 2019
mourner
pushed a commit
that referenced
this issue
Mar 25, 2019
* Use @mapbox/gazetteer for benchmark coordinates - Closes #8059 * Limit check on camelcase from external package * Use feature.properties[place_name] instead * Ignore jsonlint-lines in Flow * Add as devDependency * Upgrade `@mapbox/gazetteer` to a version that excludes dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, there's a locally managed
bench/lib/style_locations.js
file that is the mirrored version of style-benchmark-locations.json in@mapbox/gazetteer
. To keep everything in sync so that other platforms (native) are using the same location data in their benches we should replace what's here with that.The text was updated successfully, but these errors were encountered: