Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL support detection broken #677

Closed
edenh opened this issue Aug 8, 2014 · 2 comments
Closed

GL support detection broken #677

edenh opened this issue Aug 8, 2014 · 2 comments
Labels
Milestone

Comments

@edenh
Copy link
Contributor

edenh commented Aug 8, 2014

Ref #664

After disabling WebGL disabled in Safari 8, the detection script is returning true.

screen shot 2014-08-08 at 10 24 48 am

@mourner mourner added the bug label Aug 8, 2014
@mourner mourner added this to the post-v0.2.0 milestone Aug 8, 2014
@ansis
Copy link
Contributor

ansis commented Aug 8, 2014

window.WebGLRenderingContext exists even if webgl is disabled. It looks like the only reliable way to know for sure is to canvas.getContext and check if it succeeded. Our options:

  • create and discard a context
  • create a context and keep it around for the map to use
  • remove supported and have map creation fail if webgl is not supported

@jfirebaugh
Copy link
Contributor

create and discard a context

This.

@ansis ansis closed this as completed in 152c058 Aug 8, 2014
mourner added a commit that referenced this issue Aug 7, 2023
* Add GL JS v3 changelog

* Update CHANGELOG.md

Co-authored-by: Volodymyr Agafonkin <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Volodymyr Agafonkin <[email protected]>

* Update Changelog

* Update CHANGELOG.md

Co-authored-by: Volodymyr Agafonkin <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Volodymyr Agafonkin <[email protected]>

* Add link to the migration guide

* Add bullet points on Style imports

* Remove mention of 3D models

---------

Co-authored-by: Volodymyr Agafonkin <[email protected]>
mourner added a commit that referenced this issue Aug 7, 2023
* Add GL JS v3 changelog

* Update CHANGELOG.md

Co-authored-by: Volodymyr Agafonkin <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Volodymyr Agafonkin <[email protected]>

* Update Changelog

* Update CHANGELOG.md

Co-authored-by: Volodymyr Agafonkin <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Volodymyr Agafonkin <[email protected]>

* Add link to the migration guide

* Add bullet points on Style imports

* Remove mention of 3D models

---------

Co-authored-by: Volodymyr Agafonkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants