Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't request glyphs for verticalized punctuation if feature can't be verticalized #4720

Closed
ChrisLoer opened this issue May 17, 2017 · 1 comment
Closed

Don't request glyphs for verticalized punctuation if feature can't be verticalized #4720

ChrisLoer opened this issue May 17, 2017 · 1 comment
Labels
GL native → GL JS For feature parity with Mapbox Maps SDK on a native platform good first issue

Comments

@ChrisLoer
Copy link
Contributor

Port of mapbox/mapbox-gl-native#8982.

Slightly more involved fix than the gl-native side because we need to move the requests for verticalization out of glyph_source.js and into symbol_bucket.js (test for textAlongLine and allowsVerticalWritingMode before putting glyphs into the requested list with stack[text.charCodeAt(i)] = true;).

/cc @1ec5 @mb12
@ChrisLoer ChrisLoer added GL native → GL JS For feature parity with Mapbox Maps SDK on a native platform good first issue labels May 17, 2017
ChrisLoer added a commit that referenced this issue Jul 6, 2017
@ChrisLoer
Don't request vertical glyphs for labels that can't be verticalized.
0618a09 
Fixes issue #4720.
@ChrisLoer ChrisLoer mentioned this issue Jul 6, 2017
Merged
ChrisLoer added a commit that referenced this issue Jul 6, 2017
@ChrisLoer
Don't request vertical glyphs for labels that can't be verticalized.
b4332e9 
Fixes issue #4720.
@ChrisLoer
Copy link
Contributor Author

Fixed in #4941.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GL native → GL JS For feature parity with Mapbox Maps SDK on a native platform good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChrisLoer