Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotate non-CJK glyphs embedded in vertically-oriented CJK labels #3506

Closed
1ec5 opened this issue Nov 1, 2016 · 4 comments
Closed

Rotate non-CJK glyphs embedded in vertically-oriented CJK labels #3506

1ec5 opened this issue Nov 1, 2016 · 4 comments
Assignees

Comments

@1ec5
Copy link
Contributor

1ec5 commented Nov 1, 2016

Per #1246 (comment), when a label is vertically oriented with a vertical writing mode, any runs of non-CJK characters (characters that would normally be oriented horizontally) should be rotated as if the label were oriented using a horizontal writing mode.

In other words, once #3438 lands, non-CJK glyphs will remain upright when in vertically oriented labels:

Instead, these non-CJK glyphs should be rotated as they would’ve been before #3438:

On OpenStreetMap, and therefore in Mapbox Streets, mixed CJK/romanized labels are ubiquitous on roads in Hong Kong, Macao, and Shenzhen. For example, this way is tagged name=海底隧道 Cross-Harbour Tunnel. Unless we take care to rotate the Latin glyphs and advance them by the normal horizontal advance (rather than the glyph height), the label will become much longer when oriented vertically and stand a much higher chance of getting collided out.


There’s one more detail to be aware of: one- or two-digit numbers (and one- or two-letter words) would ideally be left upright, their digits placed side-by-side. This effect is called tate-chu-yoko in Japanese:

In order for this to work, we’d need to replace ASCII letters and numbers with their fullwidth or halfwidth equivalents. I think tate-chu-yoko would be a much lower priority than the suggestion above to rotate the glyphs.


The illustrations above come from the W3C’s “Requirements for Japanese Text Layout” document, which covers a number of other details needed for proper typographic treatment of Japanese text. Many of these details also apply to Chinese. However, there’s a point of diminishing returns for us, because we’re dealing with map labels rather than magazine text layout.

/cc @lucaswoj @nickidlugash @xrwang @friedbunny

@1ec5
Copy link
Contributor Author

1ec5 commented Nov 1, 2016

There may be some interplay between this issue and #3505, because we’d need to avoid rotating punctuation that lies within non-CJK text.

@lucaswoj
Copy link
Contributor

lucaswoj commented Nov 3, 2016

Rather than mark this a "release blocker", I'm going to roll this into #3438

@lucaswoj
Copy link
Contributor

Done in #3438

@1ec5
Copy link
Contributor Author

1ec5 commented Nov 10, 2016

Next steps: #3588.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants