Overlapping background-patterns break rendering

[g12n]

The rendering of multiple layers with background patterns break the rendering of these layers:

You find the source of this sample here: https://github.com/g12n/cardboard-map-gl

The sample is hosted in github pages and can be accessed here:
http://g12n.github.io/cardboard-map-gl/

I added a debug version without patterns in the gh-pages branch:
http://g12n.github.io/cardboard-map-gl/debug.html

[mourner]

Wow, that looks bad. cc @ansis

[g12n]

I still suspect it's a mistake in my Sprite. It's my first shot at it.

[g12n]

Similar Problem in Mapbox Studio:

Using multiple pattern causes Problems in Chrome on Mac.

When you zoom into the map close enough so parks appear, the park pattern is replacing the water pattern. Once the swap has happened, the water won‘t return to mobile without a browser refresh.

Test style created in Mapbox studio:

mapbox://styles/g12n/cih6bh7vl006lbpkrhtmbxjk3

Preview of the published style on Mapbox:

https://api.mapbox.com/styles/v1/g12n/cih6bh7vl006lbpkrhtmbxjk3.html?title=true&access_token=pk.eyJ1IjoiZzEybiIsImEiOiJpNnpzc2prIn0.0IvRMXsg6iYGFMrwPdpcbw#0/0/0/0

[ansis]

Thanks for the testcase @g12n

The problem was that the patterns did not fit in the sprite atlas. #141 is the underlying issue so I'll close this one. A temporary workaround would be to use smaller textures.

b016729 improves how the failure is handled by not drawing the affected layers and logging a warning to the console.

[g12n]

Since this is Happening inside MapBox Studio as well, there should be a warning in the UI for Designers as well. Are you aware of an Issue in that Project?

I created a Test-Style with quite tiny patterns.
https://api.mapbox.com/styles/v1/g12n/cij4389bp001t9pm0us902vo5.html?title=true&access_token=pk.eyJ1IjoiZzEybiIsImEiOiJpNnpzc2prIn0.0IvRMXsg6iYGFMrwPdpcbw#9.56/37.9170/14.0625

It works, but the results are more than just unsatisfactory. :|

[lyzidiamond]

Hi @g12n! We are working on the next release of Mapbox Studio right now, and we're thinking that the glyph atlas PR that will fix this ( #141) will be merged by that time, in which case there won't be an issue to warn about. Thanks for the heads up!