Skip to content

Commit

Permalink
Fix missing release testing pages due to broken CI (#11676)
Browse files Browse the repository at this point in the history
* Copying files in circleCI config to avoid symbolic links

* Fix inconsistent directory for threejs

* Updating documentation

* Slight documentation improvement

* Updating custom source release page

* Fix typo
  • Loading branch information
SnailBones authored Apr 6, 2022
1 parent f6d2cde commit d5a5145
Show file tree
Hide file tree
Showing 13 changed files with 14 additions and 13 deletions.
1 change: 1 addition & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ jobs:
- run: yarn run build-style-spec
- run: yarn run build-flow-types
- run: yarn run test-build
- run: while read l; do cp debug/$l test/release/$l; done < test/release/local_release_page_list.txt
- store_artifacts:
path: "dist"
- store_artifacts:
Expand Down
4 changes: 2 additions & 2 deletions test/release/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ To load this page, execute `npm run start-release` to build the required files,

Alternatively, you can also access the test page on Circle CI. Find a job named `build`, click the "Artifacts" tab, and navigate to the `mapbox-gl-js/test/release/index.html` page. You'll have to enter your own access token there. Before sharing the URL, be aware that it will be stored in the hash of the URL.

To add new pages to the list, add them to the `pages` object at the beginning of `index.js`. By default, it will load the HTML sample from https://github.com/mapbox/mapbox-gl-js-docs/tree/publisher-production/docs/pages/example using the ID. You can override this by specifying a custom `url` property next to the `title`.
To add new pages to the list from our online documentation, add them to the `pages` object at the beginning of `index.js`. By default, it will load the HTML sample from https://github.com/mapbox/mapbox-gl-js-docs/tree/publisher-production/docs/pages/example using the ID. You can override this by specifying a custom `url` property next to the `title`.

To add new pages from our `debug/` folder, simply create a symbolic link for the page you would like to add by running `ln -s ../../debug/page-to-add.html page-to-add.html` from this folder.
To add new pages from our `debug/` folder, add their file names to [`local_release_page_list.txt`](./local_release_page_list.txt).
1 change: 0 additions & 1 deletion test/release/custom-source.html

This file was deleted.

1 change: 0 additions & 1 deletion test/release/extrusion-query.html

This file was deleted.

1 change: 0 additions & 1 deletion test/release/featurestate.html

This file was deleted.

4 changes: 2 additions & 2 deletions test/release/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ const pages = [
"title": "Add a heatmap layer"
},
{
"key": "three-js-antenna",
"key": "threejs-antenna",
"title": "Add a 3d model on terrain with ThreeJS",
"url": "./three-js-antenna.html"
"url": "./threejs-antenna.html"
},
{
"key": "free-camera-path",
Expand Down
9 changes: 9 additions & 0 deletions test/release/local_release_page_list.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
extrusion-query.html
featurestate.html
markers.html
preload-tiles.html
projections.html
scroll_zoom_blocker.html
threejs-antenna.html
video.html
custom-source.html
1 change: 0 additions & 1 deletion test/release/markers.html

This file was deleted.

1 change: 0 additions & 1 deletion test/release/preload-tiles.html

This file was deleted.

1 change: 0 additions & 1 deletion test/release/projections.html

This file was deleted.

1 change: 0 additions & 1 deletion test/release/scroll_zoom_blocker.html

This file was deleted.

1 change: 0 additions & 1 deletion test/release/three-js-antenna.html

This file was deleted.

1 change: 0 additions & 1 deletion test/release/video.html

This file was deleted.

0 comments on commit d5a5145

Please sign in to comment.