Skip to content

Commit

Permalink
Handle Firefox SecurityError when opening window cache (#8780)
Browse files Browse the repository at this point in the history
* Catch & warn on SecurityError when opening window cache

Catch the SecurityError thrown by Firefox 69+
when the worker tries to access the cache.

Co-authored-by: Arindam Bose <[email protected]>
  • Loading branch information
2 people authored and Asheem Mamoowala committed Sep 20, 2019
1 parent f958248 commit 83ab6b7
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/util/tile_request_cache.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// @flow

import {parseCacheControl} from './util';
import {warnOnce, parseCacheControl} from './util';
import window from './window';

import type Dispatcher from './dispatcher';
Expand Down Expand Up @@ -60,7 +60,9 @@ export function cachePut(request: Request, response: Response, requestTime: numb
prepareBody(response, body => {
const clonedResponse = new window.Response(body, options);

window.caches.open(CACHE_NAME).then(cache => cache.put(stripQueryParameters(request.url), clonedResponse));
window.caches.open(CACHE_NAME)
.catch(e => warnOnce(e.message))
.then(cache => cache.put(stripQueryParameters(request.url), clonedResponse));
});
}

Expand Down

0 comments on commit 83ab6b7

Please sign in to comment.