-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update contribution guidelines per latest development changes (#10792)
* Update contribution guidelines per latest - Fix package.json node engine version to have more explicit error messages - Add .nvmrc for easier integration with nvm * Remove extraneous steps * Use previous version Locking at CVE-2020-1971 https://nodejs.org/en/blog/release/v14.15.4/ * Use >= to prevent unique version id
- Loading branch information
1 parent
c7e74bf
commit 58b7aff
Showing
3 changed files
with
8 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
14.15.4 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,9 +9,9 @@ Install the Xcode Command Line Tools Package | |
xcode-select --install | ||
``` | ||
|
||
Install [node.js](https://nodejs.org/) version ^10.15 ( Minimum 10.15 while sticking only to major version 10.0 ) | ||
Install [node.js](https://nodejs.org/) version 14 | ||
```bash | ||
brew install node | ||
brew install node@14 | ||
``` | ||
Install [yarn](https://yarnpkg.com/en/) | ||
```bash | ||
|
@@ -25,15 +25,15 @@ git clone [email protected]:mapbox/mapbox-gl-js.git | |
|
||
Install node module dependencies | ||
```bash | ||
cd mapbox-gl-js && | ||
yarn install | ||
``` | ||
|
||
### Linux | ||
|
||
Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) (version ^10.15), [GNU Make](http://www.gnu.org/software/make/), and libglew-dev | ||
Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) version 14, [GNU Make](http://www.gnu.org/software/make/), and libglew-dev | ||
This comment has been minimized.
Sorry, something went wrong. |
||
```bash | ||
sudo apt-get update && | ||
sudo apt-get update | ||
curl -sL https://deb.nodesource.com/setup_14.x | sudo bash - | ||
sudo apt-get install build-essential git nodejs libglew-dev libxi-dev | ||
``` | ||
|
||
|
@@ -50,13 +50,12 @@ git clone [email protected]:mapbox/mapbox-gl-js.git | |
|
||
Install node module dependencies | ||
```bash | ||
cd mapbox-gl-js && | ||
yarn install | ||
``` | ||
|
||
### Windows | ||
|
||
Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) (version ^10.15), [yarn](https://yarnpkg.com/en/docs/install#windows-tab), [npm and node-gyp](https://github.com/Microsoft/nodejs-guidelines/blob/master/windows-environment.md#compiling-native-addon-modules). | ||
Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) version 14, [yarn](https://yarnpkg.com/en/docs/install#windows-tab), [npm and node-gyp](https://github.com/Microsoft/nodejs-guidelines/blob/master/windows-environment.md#compiling-native-addon-modules). | ||
|
||
Clone the repository | ||
```bash | ||
|
@@ -66,7 +65,6 @@ git clone [email protected]:mapbox/mapbox-gl-js.git | |
|
||
Install node module dependencies | ||
```bash | ||
cd mapbox-gl-js | ||
yarn install | ||
``` | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
Sorry, something went wrong.
1z2x3c4v5b6n7m8Jun 24, 2021