Adding a new build Bench to be used in benchmarks (internal-241)

* Adding a new build `Bench` to be used in benchmarks * Adding minify to the Bench build
mapbox · Dec 8, 2020 · 167a043 · 167a043
1 parent ddf3e9d
commit 167a043
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 7 deletions.
diff --git a/build/rollup_plugins.js b/build/rollup_plugins.js
@@ -14,14 +14,15 @@ import replace from 'rollup-plugin-replace';
 // Common set of plugins/transformations shared across different rollup
 // builds (main mapboxgl bundle, style-spec package, benchmarks bundle)
 
-export const plugins = (minified, production, test) => [
+export const plugins = (minified, production, test, bench) => [
     flow(),
     minifyStyleSpec(),
     json(),
     production ? strip({
         sourceMap: true,
         functions: ['PerformanceUtils.*', 'Debug.*']
     }) : false,
+    production || bench ? unassert() : false,
     test ? replace({
         'process.env.CI': JSON.stringify(process.env.CI),
         'process.env.UPDATE': JSON.stringify(process.env.UPDATE)
@@ -34,7 +35,6 @@ export const plugins = (minified, production, test) => [
             passes: 3
         }
     }) : false,
-    production ? unassert() : false,
     resolve({
         browser: true,
         preferBuiltins: false

diff --git a/package.json b/package.json
@@ -122,6 +122,7 @@
   "scripts": {
     "build-dev": "rollup -c --environment BUILD:dev",
     "watch-dev": "rollup -c --environment BUILD:dev --watch",
+    "build-bench": "rollup -c --environment BUILD:bench,MINIFY:true",
     "build-prod": "rollup -c --environment BUILD:production",
     "build-prod-min": "rollup -c --environment BUILD:production,MINIFY:true",
     "build-csp": "rollup -c rollup.config.csp.js",

diff --git a/rollup.config.csp.js b/rollup.config.csp.js
@@ -15,7 +15,7 @@ const config = (input, file, format) => ({
         banner
     },
     treeshake: true,
-    plugins: plugins(true, true)
+    plugins: plugins(true, true, false)
 });
 
 export default [

diff --git a/rollup.config.js b/rollup.config.js
@@ -6,9 +6,22 @@ import banner from './build/banner';
 const {BUILD, MINIFY} = process.env;
 const minified = MINIFY === 'true';
 const production = BUILD === 'production';
-const outputFile =
-    !production ? 'dist/mapbox-gl-dev.js' :
-    minified ? 'dist/mapbox-gl.js' : 'dist/mapbox-gl-unminified.js';
+const bench = BUILD === 'bench';
+
+function buildType(build, minified) {
+    switch (build) {
+        case 'production': 
+            if (minified) return 'dist/mapbox-gl.js';
+            return 'dist/mapbox-gl-unminified.js';
+        case 'bench':
+            return 'dist/mapbox-gl-bench.js';
+        case 'dev':
+            return 'dist/mapbox-gl-dev.js';
+        default: 
+            return 'dist/mapbox-gl-dev.js';
+    }
+}
+const outputFile = buildType(BUILD, MINIFY);
 
 export default [{
     // First, use code splitting to bundle GL JS into three "chunks":
@@ -28,7 +41,7 @@ export default [{
         chunkFileNames: 'shared.js'
     },
     treeshake: production,
-    plugins: plugins(minified, production)
+    plugins: plugins(minified, production, false, bench)
 }, {
     // Next, bundle together the three "chunks" produced in the previous pass
     // into a single, final bundle. See rollup/bundle_prelude.js and