Fix blurry map-aligned labels on terrain (#10296)

* fix blurry map-pitched labels on terrain * update render tests
mapbox · Jan 15, 2021 · 07179fe · 07179fe
1 parent 4eda278
commit 07179fe
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 2 deletions.
diff --git a/src/render/program/symbol_program.js b/src/render/program/symbol_program.js
@@ -192,12 +192,12 @@ const symbolSDFUniformValues = (
     texSize: [number, number],
     isHalo: boolean
 ): UniformValues<SymbolSDFUniformsType> => {
-    const transform = painter.transform;
+    const {cameraToCenterDistance, _pitch} = painter.transform;
 
     return extend(symbolIconUniformValues(functionType, size,
         rotateInShader, pitchWithMap, painter, matrix, labelPlaneMatrix,
         glCoordMatrix, isText, texSize), {
-        'u_gamma_scale': (pitchWithMap ? Math.cos(transform._pitch) * transform.cameraToCenterDistance : 1),
+        'u_gamma_scale': pitchWithMap ? cameraToCenterDistance * Math.cos(painter.terrain ? 0 : _pitch) : 1,
         'u_device_pixel_ratio': browser.devicePixelRatio,
         'u_is_halo': +isHalo
     });

diff --git a/.../render-tests/debug/terrain/collision-pitch-with-map-text-and-icon/expected.png b/.../render-tests/debug/terrain/collision-pitch-with-map-text-and-icon/expected.png
diff --git a/test/integration/render-tests/debug/terrain/collision-pitch-with-map/expected.png b/test/integration/render-tests/debug/terrain/collision-pitch-with-map/expected.png
diff --git a/...tests/text-pitch-alignment/map-text-rotation-alignment-map-terrain/expected.png b/...tests/text-pitch-alignment/map-text-rotation-alignment-map-terrain/expected.png
diff --git a/.../text-pitch-alignment/map-text-rotation-alignment-viewport-terrain/expected.png b/.../text-pitch-alignment/map-text-rotation-alignment-viewport-terrain/expected.png