Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable proximity=ip and disabling of trackProximity #453

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Conversation

mpothier
Copy link
Contributor

@mpothier mpothier commented Mar 3, 2022

  • Adds documentation for usage of 'ip' as a value for proximity in line with the latest Geocoding API
  • Bump to latest version of mapbox-sdk-js
  • Disable trackProximity after proximity has been explicitly set via the setProximity method
  • briefly describe the changes in this PR
  • write tests for all new functionality
  • run npm run docs and commit changes to API.md
  • update CHANGELOG.md with changes under master heading before merging

- Add documentation for usage of 'ip' as a value for `proximity` in line with the latest Geocoding API
- Bump to latest version of `mapbox-sdk-js`
- Disable `trackProximity` after proximity has been explicitly set via the `setProximity` method
@mpothier mpothier marked this pull request as ready for review March 3, 2022 22:29
Copy link
Contributor

@mbullington mbullington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mpothier mpothier merged commit ea51676 into main Mar 4, 2022
@mpothier mpothier deleted the add-ip-proximity branch March 4, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants