[v4] fix focus trap #220
Merged
[v4] fix focus trap #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@scottsfarley93 I added a test to make sure that when the input is empty and in focus and then there is a keydown event from Tab that the I attempted to test under the same conditions, expect that if a different key is pressed that |
… _onKeyDown function
scottsfarley93
approved these changes
Mar 20, 2019
katydecorah
pushed a commit
that referenced
this pull request
Mar 20, 2019
* version4: (37 commits) fix focus trap (#220) add `npm run docs` step to template (#221) Fix typo in documentation additional properties existance check Ensure properties exist prior to checking id respond to @katydecorah 's code review comments update changelog deduplicate result event emissions update changelog remove use of hardcoded feature IDs update outdated packages with npm update update changelog Bump insecure dev dependencies tests for options.flyTo update changelog bump suggestions to v1.3.4 Update changelog update jsdoc and api docs pass flyTo options to map upon selection extend eslint, add precommit hook (#210) ...
katydecorah
pushed a commit
that referenced
this pull request
Mar 20, 2019
* version4: (25 commits) fix focus trap (#220) add `npm run docs` step to template (#221) Fix typo in documentation additional properties existance check Ensure properties exist prior to checking id update changelog remove use of hardcoded feature IDs update outdated packages with npm update update changelog Bump insecure dev dependencies tests for options.flyTo Update changelog update jsdoc and api docs pass flyTo options to map upon selection extend eslint, add precommit hook (#210) replace sha.js with nanoid reduce bundle size to 42kb (13kb gzipped) [docs] update deploy process (#198) prepare to publish v3.1.6 update package-lock bump package version to v3.1.5 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterheading before mergingFixes focus trap described in #162. This PR makes sure that
_onKeyDown, if the user is tabbing though do not_clearthe input because it will set the focus back on the input.