Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big dependency and dev environment cleanup #1119

Merged
merged 8 commits into from
Sep 1, 2022
Merged

Big dependency and dev environment cleanup #1119

merged 8 commits into from
Sep 1, 2022

Conversation

mourner
Copy link
Member

@mourner mourner commented Aug 31, 2022

This PR modernizes and cleans up development dependencies in the project to get rid of all security alerts and make it more maintainable. There's a lot of changes, but all commits here are self-contained so you can review one by one.

  • Remove browserify — it basically stopped being used after first step of ES6 conversion + browserify -> rollup #945 but wasn't removed.
  • Remove mapbox-gl depedency — it was used only for the Evented class used for benchmarks, but I wrote a minimal standalone Evented instead to avoid the dependency, and used CDN links for the debug/bench pages instead of serving from node_modules.
  • Remove @mapbox/flow-remove-types because it's no longer needed after eliminating mapbox-gl dependency.
  • Remove mapbox-gl-js-mock dependency — it's been unmaintained for 5 years and it was originally written for mapbox-gl-draw tests anyway, so I wrote a new mock implementation vendored in this repo.
  • Remove express and the custom server.js because after the Rollup change, we can serve everything statically.
  • Remove rollup-plugin-node-builtins because it became unnecessary after Remove GeoJSON validation #1052 — we no longer use any Node built-ins in the bundle.
  • Upgrade all dependencies to their latest versions, updating configuration where necessary.

@mourner mourner requested a review from ansis August 31, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants